[Rails-core] Still trying to get pagination fixed.. STILLhavethis
ActiveRecord connection helper thingy pending
Scott Barron
scott at elitists.net
Thu Feb 9 15:30:10 GMT 2006
On Feb 9, 2006, at 9:27 AM, Tom Ward wrote:
> On 2/9/06, Tom Ward <tom at popdog.net> wrote:
>
>> Any suggestions for a better keyword are welcome!
>
> Talking to yourself, first sign of madness and all that, but instead
> of hastests I propose 'tested', to indicate that the patch has unit
> tests, and that those tests have been run. There's no reason
> submitters shouldn't add this keyword themselves, if they wish.
>
> Tom
What also would be helpful is if you review a patch and it applies
cleanly and has tests that pass, that you not only tag it as you've
suggested but also leave a comment with the svn revision that you
reviewed it against. Sometimes things get updated or patches collide
and it would be nice to have a frame of reference to say "ok, this did
work at r12345, what's changed?" in those times.
Thanks
-Scott
More information about the Rails-core
mailing list